yagna icon indicating copy to clipboard operation
yagna copied to clipboard

`eventtype` in `/market-api/v1/agreementEvents` isn't in camelCase like the other properties

Open SewerynKras opened this issue 11 months ago • 5 comments

Issue

In the response body of /market-api/v1/agreementEvents we get all the properties in camelCase except for eventtype which is in lowercase for whatever reason. According to the openapi spec in ya-client it's supposed to be in camelCase as well:

[
  {
    eventDate: '2024-03-21T10:57:46.629739Z',
    agreementId: '<some_id>',
    eventtype: 'AgreementApprovedEvent' // <--- `eventtype` instead of `eventType`?
  }
]

Same thing happens with AgreementTerminatedEvent

I'm reporting this here because I assume this property is supposed to be in camelCase like everything else in the response body (and like the spec file suggests). If this is intended, then I'll make a PR to ya-client and change it over there.

Yagna version

$ yagna --version
yagna 0.14.0 (9f9be57b 2023-12-07 build #365)

SewerynKras avatar Mar 21 '24 11:03 SewerynKras