golem-electron icon indicating copy to clipboard operation
golem-electron copied to clipboard

ACL list not the same as from golemcli

Open maaktweluit opened this issue 5 years ago • 4 comments

Description

Golem Version: 0.22.0 release

Golem-Messages version (leave empty if unsure):

Electron version: packed with release b0.22

OS [e.g. Windows 10 Pro]: ubuntu

Branch (if launched from source):

Mainnet/Testnet: mainnet

Priority label is set to the lowest by default. To setup higher priority please change the label ??? P0 label is set for Severity-Critical/Effort-easy P1 label is set for Severity-Critical/Effort-hard P2 label is set for Severity-Low/ Effort-easy P3 label is set for Severity-Low/Effort-hard

Description of the issue:

Banned nodes do not show in GUI

Actual result:

GUI does not show any banned nodes. while golemcli acl show does

Screenshots:

Clipboard - January 16, 2020 2_50 PM

Steps To Reproduce

Short description of steps to reproduce the behavior: e.g.

  1. Launch the app
  2. Wait for handshake to fail
  3. Go to ACL tab in GUI
  4. See empty list

Expected behavior

Node that are banned also show on the GUI

Logs and any additional context

(Any additional information that could help to resolve the issue, which systems were checked to reproduce the issue) Please upload your logs if possible

Proposed Solution?

(Optional: What could be a solution for that issue)

maaktweluit avatar Jan 16 '20 13:01 maaktweluit

Are they temporary or persistent bans? @maaktweluit

mdtanrikulu avatar Jan 16 '20 14:01 mdtanrikulu

@mdtanrikulu they are temp bans

maaktweluit avatar Jan 16 '20 14:01 maaktweluit

Electron shows only permanent bans on the list.

mdtanrikulu avatar Jan 16 '20 15:01 mdtanrikulu

As discussed in chat, we keep this issue to:

  • add temp bans to the ACL list ( if UX approves )
  • add an event in golem to update electron when the ACL list is updated from golemcli

maaktweluit avatar Jan 16 '20 15:01 maaktweluit