golem icon indicating copy to clipboard operation
golem copied to clipboard

Make sure complex rib test covers all types of function inputs and function results

Open afsalthaj opened this issue 1 year ago • 1 comments

  • [ ] It's hard to maintain this test
  • [ ] Instead, generate all types of expressions based on the nodes in expr
  • [ ] Make sure all types of primitives exist at every leaf node of the expr in nodes
  • [ ] Make sure they compile
  • [ ] Next, generate a function that accepts all the types of expression. The types of expression can be reused from the second step.
  • [ ] Generate multiple of these function with varying number of arguments, and varying result types, and then an interpreter that acknowledges these result types
  • [ ] Reuse the existing pattern match and on top of it, add if else condition expressions, and combine all of them to a very complex expression, and see if interpreter runs to a success

afsalthaj avatar Sep 30 '24 12:09 afsalthaj

This ticket may rely on #942

afsalthaj avatar May 18 '25 20:05 afsalthaj

Closing as we won't further develop Rib.

vigoo avatar Aug 18 '25 18:08 vigoo