obevo icon indicating copy to clipboard operation
obevo copied to clipboard

Cleanup refactor around hash fields in Change/ChangeInput

Open shantstepanian opened this issue 7 years ago • 0 comments

A few non-ideal things in the current code:

  • Change has the original content field; should not be needed. Only there for the acceptable hashes field
  • contentHash is a field in Change (meant for persisting to db). We calculate acceptableHashes separately. They happen to be calculated in the same way, but ideally the fields should come from the same place
  • rollbackContent should not be used in the calculation classes; only "convertedRollbackContent"

shantstepanian avatar Aug 29 '18 16:08 shantstepanian