ghc icon indicating copy to clipboard operation
ghc copied to clipboard

Explicit specificity

Open goldfirere opened this issue 8 years ago • 3 comments

Take 3.

To use: Keep pushing commits to your own branch, as you've been doing. The commits will appear here as well. But this provides a place to have a conversation about the patch and for us to comment on the code with a nice interface. I don't expect that this PR will ever get merged. Instead, when the patch is ready, you'll submit to Phabricator and we'll merge into GHC central from there.

goldfirere avatar Sep 04 '17 16:09 goldfirere

Ah, okay, that makes sense. So I should not worry about pushing the "Merge pull request" button, then?

By the way, I didn't get a notification of your PR until you @-mentioned me, so good thing you checked. I marked your repository as "Watched" so now I will get such notifications in the future (although if there's enough discussion traffic on your fork then this might become cumbersome).

plaidfinch avatar Sep 04 '17 16:09 plaidfinch

This isn't really a request for anything to be pulled -- just a very convenient reviewing interface. Now that you've participated in the PR, I believe you'll get notified about future comments here. But there's very low traffic here, anyway. Sorry for not explaining earlier.

goldfirere avatar Sep 04 '17 16:09 goldfirere

No worries! I'm currently going through your comments on #73.

plaidfinch avatar Sep 04 '17 16:09 plaidfinch