golangci-lint icon indicating copy to clipboard operation
golangci-lint copied to clipboard
verified publisher icon golangci

build(deps): bump github.com/go-critic/go-critic from 0.6.3 to 0.6.4

Open dependabot[bot] opened this issue 3 years ago • 2 comments

Bumps github.com/go-critic/go-critic from 0.6.3 to 0.6.4.

Release notes

Sourced from github.com/go-critic/go-critic's releases.

v0.6.4

A special thanks goes to @​mcdoker18, @​cristaloleg and @​peakle + everyone who helps to keep this project afloat.

Commits
  • d9c2d89 update ruleguard to 0.3.17 (#1249)
  • dfd27d0 checkers: use ctx.SizeOf instead of SizesInfo.SizeOf (#1247)
  • f1528e1 checkers: supported generics for typeDefFirst and paramTypeCombine (#1239)
  • af0e6d7 checkers: don't call SizeOf for type parameters (#1237)
  • 8df9d7e checkers: turn init() for embedded rules into exported func (#1246)
  • 1d7d822 ci: add Go 1.18 (#1240)
  • 4f19cad deps: bump github.com/cristalhq/acmd from 0.5.7 to 0.7.0 (#1236)
  • 7cb5c45 deps: bump toolmantim/release-drafter from 5.2.0 to 5.20.0 (#1231)
  • ed6b4df deps: bump actions/setup-go from 1 to 3 (#1228)
  • 7c630aa deps: bump actions/checkout from 1 to 3 (#1229)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot[bot] avatar Aug 11 '22 23:08 dependabot[bot]

The failure due to the embedded rules that were moved to checkers.InitEmbeddedRules(). If it's not called, embedded rules are not "registered". My guess is that when we'll add a checkers.InitEmbeddedRules() call when gocritic is enabled, this issue will go away.

quasilyte avatar Aug 12 '22 07:08 quasilyte

I will have to rewrite the configuration parsing.

ldez avatar Aug 12 '22 09:08 ldez

Thank you

ccoVeille avatar Aug 14 '22 20:08 ccoVeille

How long do you think it will take for a new version to be released that has this change?

hakankoklu avatar Aug 16 '22 18:08 hakankoklu

Is go-critic supposed to work with a package containing generic code, with golangci-lint v1.49.0 ? I still get a panic with an "unreachable" message. I can provide a proper debug log or open an issue if you want.

Yes my GOROOT variable is set.

pierrre avatar Aug 24 '22 16:08 pierrre

@pierrre can you put your feedback in the issue (with the output stack) https://github.com/golangci/golangci-lint/issues/3107

ldez avatar Aug 24 '22 16:08 ldez

@pierrre maybe you can create a new issue because your problem seems not related to #3107

ldez avatar Aug 24 '22 16:08 ldez