golangci-lint icon indicating copy to clipboard operation
golangci-lint copied to clipboard

feat: Include custom linters in `enable-all`

Open yuqengo opened this issue 1 year ago • 4 comments

Related to https://github.com/golangci/golangci-lint/issues/3080

.golangci.yml

linters-settings:
  custom:
    example:
      path: ./example.so

linters:
  enable-all: true

Custom linters work for enable-all.

yuqengo avatar Aug 09 '22 13:08 yuqengo

Hey, thank you for opening your first Pull Request !

boring-cyborg[bot] avatar Aug 09 '22 13:08 boring-cyborg[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 09 '22 13:08 CLAassistant

Hello,

for security reasons, I think it's a bad idea to do that.

ldez avatar Aug 09 '22 14:08 ldez

Hello, Thanks for review!

What security reasons do you have?

yuqengo avatar Aug 09 '22 17:08 yuqengo

I thought about the subject and I think there is a bug because the activation of plugins should be done by default. https://github.com/golangci/golangci-lint/blob/011252127f53cf6a0f2b28dc97fed55508575b09/pkg/lint/lintersdb/manager.go#L983

The current implementation inside golangci-lint has some design problems.

I think I will fix design problems and the behavior of the plugin in another PR.

ldez avatar Jun 12 '23 08:06 ldez

@ldez hello idez !

The current implementation inside golangci-lint has some design problems. I think I will fix design problems and the behavior of the plugin in another PR.

If you respond with another PR, Should this PR be closed ?

yuqengo avatar Jun 14 '23 15:06 yuqengo

Yes, I will create a new PR tomorrow.

ldez avatar Jun 14 '23 16:06 ldez