golangci-lint icon indicating copy to clipboard operation
golangci-lint copied to clipboard

GoKart support

Open mykter opened this issue 4 years ago • 11 comments

Your feature request related to a problem? Please describe.

GoKart is a new stand-alone security-focused static analysis tool.

Describe the solution you'd like.

Add support for GoKart. It uses go/analysis.

Describe alternatives you've considered.

Run GoKart separately to golangci-lint.

Additional context.

No response

mykter avatar Aug 19 '21 15:08 mykter

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

boring-cyborg[bot] avatar Aug 19 '21 15:08 boring-cyborg[bot]

I think it will be much faster if you can raise a PR. Any new linters that are not already covered by existent are welcome

SVilgelm avatar Aug 19 '21 19:08 SVilgelm

I would like to work on this, can you please assign this to me?

shubham1172 avatar Feb 23 '22 13:02 shubham1172

no worries, you can just raise a PR

SVilgelm avatar Feb 23 '22 14:02 SVilgelm

Hi, @shubham1172 I am wondering if you are still working on this? If not, I'd like to complete this issue XD

SpikeWong avatar Sep 02 '22 10:09 SpikeWong

Hello @anoymouscoder, you can take it up!

shubham1172 avatar Sep 02 '22 10:09 shubham1172

/assign

SpikeWong avatar Sep 02 '22 10:09 SpikeWong

@SVilgelm Because this issue has been raised for a long time, I would like to reconfirm whether there are existent or similar linters

SpikeWong avatar Sep 02 '22 10:09 SpikeWong

@SVilgelm Because this issue has been raised for a long time, I would like to reconfirm whether there are existent or similar linters

@ldez Could you help confirm this?

SpikeWong avatar Sep 05 '22 06:09 SpikeWong

By looking at the list of linters a linter that seems related is gosec but no full overlap.

I noticed that GoKart seems somewhat abandoned. Last commit was 26 January 2022 (7+ months ago) and there are issues and PRs back from September 2021 that has got no attention from any maintainer. This is not a great sign since we would need to be able to get feedback from potential issues or PRs that we might discover if implementing this in golangci-lint.

bombsimon avatar Sep 05 '22 06:09 bombsimon

@bombsimon Thanks for your reply, I got it. So do we need to close this issue or keep watching the gokart project?

SpikeWong avatar Sep 05 '22 08:09 SpikeWong