website icon indicating copy to clipboard operation
website copied to clipboard

wasi: update wasm runtime file location

Open Zxilly opened this issue 1 year ago • 9 comments

Updates golang/go#68024

Zxilly avatar Aug 13 '24 08:08 Zxilly

This PR (HEAD: 0dbc80f9376dbe793dd59a1ccff0c530fe9ac568) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/website/+/604916.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Aug 13 '24 09:08 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/604916. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 13 '24 09:08 gopherbot

Message from Zxilly Chou:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/604916. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 13 '24 09:08 gopherbot

Message from Johan Brandhorst-Satzkorn:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/604916. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 13 '24 16:08 gopherbot

This PR (HEAD: 7fbfab22921d57ebf13586494ff7699ddeb9e473) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/website/+/604916.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Aug 13 '24 17:08 gopherbot

Message from Zxilly Chou:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/604916. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 13 '24 17:08 gopherbot

Message from Johan Brandhorst-Satzkorn:

Patch Set 2: Code-Review+1 Hold+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/604916. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 13 '24 18:08 gopherbot

Message from Eli Bendersky‎:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/604916. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 30 '24 20:08 gopherbot

Message from Zxilly Chou:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/604916. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 30 '24 21:08 gopherbot

Message from Dmitri Shuralyov:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/604916. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 02 '24 17:10 gopherbot

Message from Dmitri Shuralyov:

Patch Set 2: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/604916. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 02 '24 17:10 gopherbot

Message from Johan Brandhorst-Satzkorn:

Patch Set 2: -Hold Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/604916. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 02 '24 17:10 gopherbot

Message from Johan Brandhorst-Satzkorn:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/604916. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 02 '24 17:10 gopherbot

Message from Eli Bendersky:

Patch Set 2: Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/604916. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 02 '24 18:10 gopherbot

Message from Dmitri Shuralyov:

Patch Set 2: Auto-Submit+1 Commit-Queue+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/604916. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 02 '24 19:10 gopherbot

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-02T19:10:28Z","revision":"5bd85909951a28f9a5e11f7544962be921ba6f5a"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/604916. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 02 '24 19:10 gopherbot

This PR is being closed because golang.org/cl/604916 has been merged.

gopherbot avatar Oct 02 '24 19:10 gopherbot