website icon indicating copy to clipboard operation
website copied to clipboard

Remove comment from hello example

Open peterhellberg opened this issue 4 years ago • 4 comments

Remove comment in order to reduce the number of wasted lines in https://go.dev/play/ (The current design shows fewer lines of code than the old version of the playground)

Users would otherwise have to manually remove these each time they want to share a snippet on the playground.

peterhellberg avatar Nov 29 '21 10:11 peterhellberg

Signed the CLA after opening the PR.

peterhellberg avatar Nov 29 '21 10:11 peterhellberg

I think that the comment is in fact useful for new comers. It might also be useful when sending a Playground link (after code edit) to someone else, so this would not be a problem to many people who start from this example.

I have much concerns about the screen space wasted with the new UI of the Go Playground (2 third of screen wasted on desktop to show other things than the code) but the example code is not a problem from my point of view.

dolmen avatar Nov 29 '21 10:11 dolmen

This PR (HEAD: ac3e38f4af31b01dfddbdf2be7e01b3c4a2aee55) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/367474 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Nov 29 '21 10:11 gopherbot

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/367474. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 29 '21 11:11 gopherbot