vscode-go icon indicating copy to clipboard operation
vscode-go copied to clipboard

extension/package.json: fix typo in debug/callstack/context

Open DrSergei opened this issue 6 months ago • 5 comments

This patch fixes problem when user try debug not golang program, but see "Go: Toggle Hide System Goroutines" command for threads in callstack view.

DrSergei avatar Jun 06 '25 21:06 DrSergei

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 06 '25 21:06 google-cla[bot]

This PR (HEAD: 960b9bcf9e53a3d2ada514e0ca93bf99c1068bb2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/679795.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Jun 06 '25 21:06 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 06 '25 21:06 gopherbot

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 06 '25 21:06 gopherbot

Message from Сергей Дружков:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 11 '25 14:06 gopherbot

Message from Сергей Дружков:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 21 '25 12:07 gopherbot

Message from Madeline Kalil:

Patch Set 2: Commit-Queue+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 21 '25 14:07 gopherbot

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-21T14:35:38Z","revision":"f88e4e04c97736bd6da1dd735e6d194159a9ee73"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 21 '25 14:07 gopherbot

Message from Madeline Kalil:

Patch Set 2: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 21 '25 14:07 gopherbot

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/x_vscode-go-gotip-linux-amd64_docker has failed with summary (view all results):


To reproduce, try gomote repro 8708726172066876321.

Additional links for debugging:


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 21 '25 14:07 gopherbot

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 21 '25 14:07 gopherbot

This PR (HEAD: 5d2a74e9cef27b817a874a0a6ff77b057b0fec31) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/679795.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Jul 22 '25 08:07 gopherbot

Message from Сергей Дружков:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 22 '25 09:07 gopherbot

Message from Hongxiang Jiang:

Patch Set 3: Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 23 '25 21:07 gopherbot

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-23T21:11:54Z","revision":"c37902ba952b90ffab0a0c93768526d5f370a305"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 23 '25 21:07 gopherbot

Message from kokoro:

Patch Set 3:

Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit Logs at: http://sponge2.corp.google.com/3bda8af4-ce64-4208-88ad-3b8468f5cdf5


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 23 '25 21:07 gopherbot

Message from kokoro:

Patch Set 3:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Logs at: https://source.cloud.google.com/results/invocations/3bda8af4-ce64-4208-88ad-3b8468f5cdf5


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 23 '25 21:07 gopherbot

Message from kokoro:

Patch Set 3: kokoro-CI+1

Kokoro presubmit build finished with status: SUCCESS Logs at: https://source.cloud.google.com/results/invocations/3bda8af4-ce64-4208-88ad-3b8468f5cdf5


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 23 '25 21:07 gopherbot

Message from Hongxiang Jiang:

Patch Set 3: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 23 '25 21:07 gopherbot

Message from Go LUCI:

Patch Set 3:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 23 '25 21:07 gopherbot

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 23 '25 21:07 gopherbot

Message from Сергей Дружков:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 04 '25 18:08 gopherbot

Message from Сергей Дружков:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 18 '25 20:08 gopherbot

Message from Madeline Kalil:

Patch Set 3: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 19 '25 15:08 gopherbot

Message from Hongxiang Jiang:

Patch Set 3: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/679795. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 19 '25 18:08 gopherbot

This PR is being closed because golang.org/cl/679795 has been merged.

gopherbot avatar Aug 19 '25 18:08 gopherbot