vscode-go icon indicating copy to clipboard operation
vscode-go copied to clipboard

format: resolve variables in customFormatter field

Open uniquefine opened this issue 1 year ago • 7 comments

Fixes #2582

uniquefine avatar Aug 16 '23 09:08 uniquefine

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 16 '23 09:08 google-cla[bot]

This PR (HEAD: cec997d7977413704f89365bea1782a1db0664b6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/520015.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to register for Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Aug 16 '23 12:08 gopherbot

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/520015. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 16 '23 12:08 gopherbot

@uniquefine Are you still planning to get this PR merged? I would love to see this long-standing issue get closed, as I have some code that would be able to take advantage of the fix.

dcarney-stripe avatar Jan 17 '24 17:01 dcarney-stripe

Yes, I was waiting for a review. I'll resolve the conflicts and ping the maintainers in slack.

uniquefine avatar Jan 18 '24 07:01 uniquefine

🚀

Olshansk avatar Jan 19 '24 21:01 Olshansk

I encountered the same issue. In my case, I want to add -local xxx argument to goimports, which seems not doable using go.formatTool=goimports. I created a goimports.sh within the workspace and tried to call it, but it failed with "not found" error message.

telnet2 avatar Jan 24 '24 19:01 telnet2

@uniquefine What's left to get this merged? I'd still really like to see it get merged in.

dcarney-stripe avatar Mar 12 '24 20:03 dcarney-stripe

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/520015. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 04 '24 00:04 gopherbot

This PR is being closed because golang.org/cl/520015 has been abandoned.

Submitted rebased change https://go-review.git.corp.google.com/c/vscode-go/+/576296

gopherbot avatar Apr 04 '24 14:04 gopherbot