vscode-go
vscode-go copied to clipboard
golang
debug: respect go test flags usage
The go test require the package list appear before any flag unknown to the go test command.
But vscode-go constructs arguments for the go test call with testify that doesn't respect the usage.
This PR fixes this problem by filling in the package list first.
Fixes: #1831
This PR (HEAD: fe6720d3b8ec55927db1a3df38bb44438afde503) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/vscode-go/+/425835 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
Message from Jamal Carvalho:
Patch Set 2: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 2:
Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Logs at: https://source.cloud.google.com/results/invocations/2f3a2a0f-2c8f-42dc-87fc-35ad4ea6cd9a
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 2: TryBot-Result-1
Kokoro presubmit build finished with status: FAILURE Logs at: https://source.cloud.google.com/results/invocations/2f3a2a0f-2c8f-42dc-87fc-35ad4ea6cd9a
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
Message from Jamal Carvalho:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: dd931e4023241e9168636822d72ecf33c00e3cd3) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/vscode-go/+/425835 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from leo steve:
Patch Set 3:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
Message from Hyang-Ah Hana Kim:
Patch Set 3: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 3:
Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Logs at: https://source.cloud.google.com/results/invocations/4ef79603-c794-4a3b-81b9-037bdd2dd747
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 3: TryBot-Result-1
Kokoro presubmit build finished with status: FAILURE Logs at: https://source.cloud.google.com/results/invocations/4ef79603-c794-4a3b-81b9-037bdd2dd747
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 42ec3e852d1540786c0091692ce0668e5fc131bc) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/vscode-go/+/425835 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from leo steve:
Patch Set 4:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
Message from Jamal Carvalho:
Patch Set 4: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 4:
Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Logs at: https://source.cloud.google.com/results/invocations/b9782042-27cf-4c72-b039-03bd2ae738e6
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 4: TryBot-Result-1
Kokoro presubmit build finished with status: FAILURE Logs at: https://source.cloud.google.com/results/invocations/b9782042-27cf-4c72-b039-03bd2ae738e6
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 98a9bdb777b44fe3e34de12888140eaad1ea8c7a) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/vscode-go/+/425835 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from leo steve:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
Message from Jamal Carvalho:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
Message from leo steve:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
Message from leo steve:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
Message from Jamal Carvalho:
Patch Set 5: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 5:
Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit Logs at: https://source.cloud.google.com/results/invocations/00e33dfe-207f-4046-9cbb-1a3691ef327a
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 5: TryBot-Result+1
Kokoro presubmit build finished with status: SUCCESS Logs at: https://source.cloud.google.com/results/invocations/00e33dfe-207f-4046-9cbb-1a3691ef327a
Please don’t reply on this GitHub thread. Visit golang.org/cl/425835. After addressing review feedback, remember to publish your drafts!
This was never merged. #1831 is still open. It really looks like this will fix it. Any chance of some help form the team here?
I also ran into this issue, on a CGO project which requires ldflags+extflags on macOS. The impact is that my project cannot test or debug tests on VSC on macOS.
