tools
tools copied to clipboard
golang
gopls/internal: add code action "extract declarations to new file"
This code action moves selected code sections to a newly created file within the same package. The created filename is chosen as the first {function, type, const, var} name encountered. In addition, import declarations are added or removed as needed.
Fixes golang/go#65707
This PR (HEAD: 8c85d4325defb60788953717355576bed48ca31f) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
Message from [email protected]:
Patch Set 1:
(5 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 46ec4ff0218dde2c30dd30a663355bf827defacf) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from [email protected]:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
Message from Chiawen Chen:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
Message from Chiawen Chen:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
Message from Chiawen Chen:
Patch Set 2:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
Message from Chiawen Chen:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 2:
(13 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: da8e51ffbe93fa1fbe2280dc92b34c701ac1847f) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Chiawen Chen:
Patch Set 2:
(16 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 4:
(39 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: fa8abe391a68b5132fc1ec65e5993651e3e88f73) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Chiawen Chen:
Patch Set 4:
(34 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 549739f46d7a3cb41882f4c1752f20214169174d) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Chiawen Chen:
Patch Set 5:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 6:
(37 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 6:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 1a5533fa2d577c6032ed6a96728a486f84e4cc50) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Chiawen Chen:
Patch Set 7:
(29 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 7:
(23 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: aacfc85c7fdd1faabb829976bbafe0cd71d28a6f) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Chiawen Chen:
Patch Set 7:
(22 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 8:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 37c696cb18ae768019920ebe5963247670bec781) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Chiawen Chen:
Patch Set 8:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 9: Commit-Queue+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 9:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-06-18T15:15:38Z","revision":"c53f44fd71d3fb0c463b57c0f8120f12c393a143"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 9: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/565895. After addressing review feedback, remember to publish your drafts!