tools icon indicating copy to clipboard operation
tools copied to clipboard

go/ssa: add associated documentation to functions

Open aykevl opened this issue 6 years ago • 7 comments

This makes it easier for clients to read compiler directives like //go:linkname or //line.

I would like to use this in my own Go compiler project.

aykevl avatar Aug 26 '18 18:08 aykevl

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/131283. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 26 '18 18:08 gopherbot

Message from Gerrit User 5195:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/131283. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 29 '18 19:08 gopherbot

Message from Gerrit User 5020:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/131283. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 29 '18 20:08 gopherbot

Message from Gerrit User 5195:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/131283. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 30 '18 16:08 gopherbot

Message from Alan Donovan:

Patch Set 1: Code-Review-1


Please don’t reply on this GitHub thread. Visit golang.org/cl/131283. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 09 '18 15:11 gopherbot

Message from Ayke van Laethem:

Patch Set 1:

Oops, I forgot about this change. I have used you


Please don’t reply on this GitHub thread. Visit golang.org/cl/131283. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 10 '18 00:11 gopherbot

Message from Ayke van Laethem:

Patch Set 1:

Patch Set 1:

Oops, I forgot about this change. I have used you

*I have used your change and it has worked well for me. (Hit the wrong button).


Please don’t reply on this GitHub thread. Visit golang.org/cl/131283. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 10 '18 00:11 gopherbot