tools
tools copied to clipboard
golang
cmd/bundle: add support for embedded generic structs
The current implementation fails to rename field selectors that refer to embedded generic structs. This commit addresses this issue.
It also replaces calls to the deprecated io/ioutil package with calls to the os package, and there is a code simplification regarding a use of strings.Replace.
Fixes #60647
This PR (HEAD: c49f84c8015e6d1e712bd444875ae36d0bd83d25) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/502956 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/502956. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: a014f73ebb96aa8f7ff73a540e25729e76800634) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/502956 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Alan Donovan:
Patch Set 2:
(4 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/502956. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 3a845c4381a32338ec20549daea993c7f64d79ca) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/502956 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from [email protected]:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/502956. After addressing review feedback, remember to publish your drafts!