tools
tools copied to clipboard
golang
gopls/internal/lsp: add go to implementation support for function types
This PR (HEAD: 79b5e63563b9d33039b302a5ae82f7632a874e2a) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/448035 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Robert Findley:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 1:
(4 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 952df4b7233aebcb330b4931dadae8a472ace9e9) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/448035 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Adrian Hesketh:
Patch Set 2:
(4 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 2:
(5 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 02be8857d74551ffeb5648b9607c8393d3ef0e78) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/448035 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Adrian Hesketh:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: c978bede59999da0e08efec7dc4a3ef3370d3c03) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/448035 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Adrian Hesketh:
Patch Set 4:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 1dc58ee146ec697e886d93e975e9d159b1e4a22c) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/448035 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Adrian Hesketh:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 5:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. After addressing review feedback, remember to publish your drafts!
Message from Adrian Hesketh:
Patch Set 5:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/448035. After addressing review feedback, remember to publish your drafts!
I took a break from it to try and understand the Go language spec better, because I felt that I didn't fully understand all the points coming back the code review, and now it's out of date. I did think about getting back to this at some point.
There's no generic test case, so this PR might not.