tools icon indicating copy to clipboard operation
tools copied to clipboard

gopls/Suppress completion of filtered directory packages.

Open gonzojive opened this issue 3 years ago • 5 comments

Attempted fix for https://github.com/golang/go/issues/52347.

I am not very familiar with gopls internals, so this may not be the best implementation, but it seems to solve my problem for now.

gonzojive avatar Apr 19 '22 06:04 gonzojive

This PR (HEAD: 50125c05cbcb595fb2ff4b2344d38193c04fe455) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/400835 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Apr 19 '22 06:04 gopherbot

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/400835. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 19 '22 06:04 gopherbot

Message from Peter Weinberger:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/400835. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 20 '22 14:04 gopherbot

Message from Peter Weinberger:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/400835. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 09 '22 23:05 gopherbot

Message from Peter Weinberger:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/400835. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 12 '22 15:05 gopherbot