tools
tools copied to clipboard
golang
internal/span: fix URI.IsFile() to support local-path URIs
Fixes golang/go#49501
Updates internal/span/URI.IsFile() to accept a file: URI using a local-path.
This PR (HEAD: 83c783616b6a375260a578efd65ea806b1e54973) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/376234 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/376234. After addressing review feedback, remember to publish your drafts!
Message from Ian Cottrell:
Patch Set 1: Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/376234. After addressing review feedback, remember to publish your drafts!
Message from Robert Findley:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/376234. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 765532144ad43a390a8972abc44f7869ec36ca91) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/376234 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Robert Findley:
Patch Set 2: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/376234. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/376234. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 2:
Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit Logs at: https://source.cloud.google.com/results/invocations/60b2c35f-411e-4ab3-9ffc-41913263edb3
Please don’t reply on this GitHub thread. Visit golang.org/cl/376234. After addressing review feedback, remember to publish your drafts!
Message from kokoro:
Patch Set 2: gopls-CI+1
Kokoro presubmit build finished with status: SUCCESS Logs at: https://source.cloud.google.com/results/invocations/60b2c35f-411e-4ab3-9ffc-41913263edb3
Please don’t reply on this GitHub thread. Visit golang.org/cl/376234. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 2: TryBot-Result+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/376234. After addressing review feedback, remember to publish your drafts!