tools icon indicating copy to clipboard operation
tools copied to clipboard

present: add support for full screen mode

Open lucor opened this issue 7 years ago • 15 comments

This pull request add the -fullscreen flag to enable full screen mode (default: false). When enabled all the slides except the current one are hidden.

Fixes golang/go#12634 Fixes golang/go#18299

lucor avatar Mar 21 '18 18:03 lucor

This PR (HEAD: 1c65b8c7d8486976be44d0294ae5832cd8221087) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/tools/+/101956 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Mar 21 '18 18:03 gopherbot

Message from Gerrit Bot:

Uploaded patch set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101956. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 21 '18 18:03 gopherbot

Message from Tobias Klauser:

Patch Set 2:

(3 comments)

Thanks. Please see a few comments regarding the commit message format.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101956. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 21 '18 19:03 gopherbot

Message from Gerrit Bot:

Uploaded patch set 3: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101956. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 21 '18 20:03 gopherbot

Message from Luca Corbo:

Patch Set 3:

(3 comments)

I've updated the commit message format. Thanks for your feedback.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101956. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 21 '18 20:03 gopherbot

Message from Tobias Klauser:

Patch Set 3: Code-Review+1

(1 comment)

One small nit, otherwise LGTM.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101956. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 21 '18 22:03 gopherbot

Message from Luca Corbo:

Patch Set 3:

(1 comment)

Patch Set 3: Code-Review+1

(1 comment)

One small nit, otherwise LGTM.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101956. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 22 '18 18:03 gopherbot

Message from Tobias Klauser:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/101956. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 28 '18 09:03 gopherbot

This would be super useful, can this be merged?

ebenoist avatar Sep 11 '19 19:09 ebenoist

Whats holding this back? Would be nice to not have to zoom the browser every time i do a presentation...

jonaz avatar Sep 07 '20 13:09 jonaz

Message from Gerrit User 19560:

Patch Set 2:

(3 comments)

Thanks. Please see a few comments regarding the commit message format.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101956. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot

Message from Gerrit User 26935:

Patch Set 3:

(3 comments)

I've updated the commit message format. Thanks for your feedback.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101956. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot

Message from Gerrit User 19560:

Patch Set 3: Code-Review+1

(1 comment)

One small nit, otherwise LGTM.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101956. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot

Message from Gerrit User 26935:

Patch Set 3:

(1 comment)

Patch Set 3: Code-Review+1

(1 comment)

One small nit, otherwise LGTM.


Please don’t reply on this GitHub thread. Visit golang.org/cl/101956. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot

Message from Gerrit User 19560:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/101956. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot