tools icon indicating copy to clipboard operation
tools copied to clipboard

internal/imports: remove duplicate unused imports

Open Deiz opened this issue 4 years ago • 12 comments

Track imports per identifier as a slice to accommodate duplicates. This allows us to generate multiple import fixes per import identifier.

Fixes golang/go#45398

Deiz avatar Apr 05 '21 20:04 Deiz

This PR (HEAD: 79f5729da29d44425eb9faf5247dfac3b4f1d433) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/307449 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Apr 05 '21 20:04 gopherbot

Message from Heschi Kreinick:

Patch Set 1: Run-TryBot+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/307449. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 05 '21 22:04 gopherbot

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=6557c927


Please don’t reply on this GitHub thread. Visit golang.org/cl/307449. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 05 '21 22:04 gopherbot

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit Logs at: https://source.cloud.google.com/results/invocations/deda36c2-b38e-4079-8756-0fead95faad5


Please don’t reply on this GitHub thread. Visit golang.org/cl/307449. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 05 '21 22:04 gopherbot

Message from kokoro:

Patch Set 1: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS Logs at: https://source.cloud.google.com/results/invocations/deda36c2-b38e-4079-8756-0fead95faad5


Please don’t reply on this GitHub thread. Visit golang.org/cl/307449. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 05 '21 22:04 gopherbot

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/307449. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 05 '21 22:04 gopherbot

@heschi anything blocking merge on this?

Deiz avatar Oct 15 '21 00:10 Deiz

Message from Heschi Kreinick:

Patch Set 1: Run-TryBot+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/307449. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=6557c927


Please don’t reply on this GitHub thread. Visit golang.org/cl/307449. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit Logs at: https://source.cloud.google.com/results/invocations/deda36c2-b38e-4079-8756-0fead95faad5


Please don’t reply on this GitHub thread. Visit golang.org/cl/307449. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot

Message from kokoro:

Patch Set 1: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS Logs at: https://source.cloud.google.com/results/invocations/deda36c2-b38e-4079-8756-0fead95faad5


Please don’t reply on this GitHub thread. Visit golang.org/cl/307449. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/307449. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot