tools
tools copied to clipboard
golang
goyacc: reduce dependence on globals
This is my attempt at resolving goyacc's dependence on certain global variables
Fixes golang/go#44774
This PR (HEAD: a965a571dd795205ab6582d15ea92e1350374b58) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/298389 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Go Bot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/298389. After addressing review feedback, remember to publish your drafts!
Message from roger peppe:
Patch Set 1: Code-Review-1
(5 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/298389. After addressing review feedback, remember to publish your drafts!
Message from Eric Bajumpaa:
Patch Set 1:
(5 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/298389. After addressing review feedback, remember to publish your drafts!
Message from Eric Bajumpaa:
Patch Set 1:
(5 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/298389. After addressing review feedback, remember to publish your drafts!