tools
tools copied to clipboard
golang
present: properly render sub-section heading
This fixes: https://github.com/golang/go/issues/6846
If we take the example from the readme:
# Title of Talk
My Name
9 Mar 2020
[email protected]
## Title of Slide or Section (must begin with ##)
Some Text
### Subsection {#anchor}
- bullets
- more bullets
- a bullet continued
on the next line
#### Sub-subsection
Some More text
The sub-section and sub-subsection will have the headings <h2> and <h3> respectively, which breaks the page, since the main title has a heading of <h3> so it pushes down the sub-section to the bottom of the page.
If we use .Level for the section heading, they will have the headings <h3> and <h4> which will render properly.
This PR (HEAD: b56102bf1504693b1e211e257575b2ad0573d7b3) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/240018 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gobot Gobot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!
Message from Robert Findley:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!
Message from Gorka Lerchundi Osa:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 3: Published edit on patch set 2.
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 3:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!
Message from Filip Nikolovski:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 91ef97bf0ebd25ce4d209abcf391bc31302aafa2) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/240018 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Filip Nikolovski:
Patch Set 4:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!
Message from Gorka Lerchundi Osa:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 3: Published edit on patch set 2.
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 3:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!
Message from Filip Nikolovski:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!
Message from Filip Nikolovski:
Patch Set 4:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. After addressing review feedback, remember to publish your drafts!