tools
tools copied to clipboard
golang
present: support markdown table
This PR (HEAD: 7c1df7db2b0b92daa2dffacb07f3410670623b40) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/226208 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Rebecca Stambler:
Patch Set 1: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 1:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=bca07cc9
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 1: TryBot-Result+1
TryBots are happy.
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from Andrew Bonventre:
Patch Set 1: Run-TryBot+1
(1 comment)
+rsc
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from Andrew Bonventre:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 5fd3dbf014fe1de3ac98dc1d89d6da979e999382) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/226208 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
This PR (HEAD: 166b17f8a6ed01bd19623ff0b67e83c5d9aff706) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/226208 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
This PR (HEAD: 0bbdd3540ea1425a7dc7a24b5336d9be4667e689) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/226208 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from peter zhang:
Patch Set 5:
please review again
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 5:
Please add a test in testdata/table.md so we don't break this functionality in the future. Otherwise seems fine. Thanks.
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 5:
Also if you could please change your Author line to use the full name we have in the CONTRIBUTORS file (Peter Zhang), that would help us when looking through history.
git commit --amend --author='Peter Zhang [email protected]' should do it.
Thanks again.
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from peter zhang:
Patch Set 5:
done
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: e54f61b28880ba55f6d14c137620fd121076b232) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/226208 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Andrew Bonventre:
Patch Set 6: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 6:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=67e5159e
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 6:
Build is still in progress... This change failed on freebsd-amd64-12_0: See https://storage.googleapis.com/go-build-log/748533e3/freebsd-amd64-12_0_1768acf2.log
Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 6: TryBot-Result-1
10 of 10 TryBots failed: Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/748533e3/freebsd-amd64-12_0_1768acf2.log Failed on linux-amd64 (Go 1.13.x): https://storage.googleapis.com/go-build-log/237b6067/linux-amd64_c5050684.log Failed on linux-amd64 (Go 1.14.x): https://storage.googleapis.com/go-build-log/f758dabf/linux-amd64_743a202f.log Failed on linux-386: https://storage.googleapis.com/go-build-log/748533e3/linux-386_80539f77.log Failed on linux-amd64: https://storage.googleapis.com/go-build-log/748533e3/linux-amd64_b0299877.log Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/748533e3/windows-amd64-2016_e635113f.log Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/748533e3/openbsd-amd64-64_7a4ee4fb.log Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/748533e3/windows-386-2008_b2ff82a1.log Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/748533e3/android-amd64-emu_936c481f.log Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/748533e3/linux-amd64-race_8e96811d.log
Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from Andrew Bonventre:
Patch Set 7: Patch Set 6 was rebased
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from Andrew Bonventre:
Patch Set 7: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 7:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=314f4c0a
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 7:
Build is still in progress... This change failed on linux-386: See https://storage.googleapis.com/go-build-log/e3491c46/linux-386_52a30909.log
Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 7: TryBot-Result-1
10 of 10 TryBots failed: Failed on linux-386: https://storage.googleapis.com/go-build-log/e3491c46/linux-386_52a30909.log Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/e3491c46/freebsd-amd64-12_0_349d132a.log Failed on linux-amd64 (Go 1.13.x): https://storage.googleapis.com/go-build-log/237b6067/linux-amd64_a541860e.log Failed on linux-amd64: https://storage.googleapis.com/go-build-log/e3491c46/linux-amd64_60e577b6.log Failed on linux-amd64 (Go 1.14.x): https://storage.googleapis.com/go-build-log/f758dabf/linux-amd64_fae6824e.log Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/e3491c46/windows-amd64-2016_b763c38a.log Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/e3491c46/openbsd-amd64-64_02af4d09.log Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/e3491c46/linux-amd64-race_2f44f167.log Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/e3491c46/android-amd64-emu_f738738a.log Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/e3491c46/windows-386-2008_7342003d.log
Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from Andrew Bonventre:
Patch Set 7: -Run-TryBot
The tests are failing. Please take a look and fix before we can move forward. Thanks.
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 87ddc8719e565204d28f4c978d9f601d353f74ee) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/226208 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from peter zhang:
Patch Set 8:
Run-TryBot = +1
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from peter zhang:
Patch Set 8:
Run-TryBot
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
Message from peter zhang:
Patch Set 8:
(1 comment)
Patch Set 7: -Run-TryBot
The tests are failing. Please take a look and fix before we can move forward. Thanks.
rebase my branch to origin master, please try again?
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: a44ee55f82627cea46b5ef447eef4594401523dd) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/226208 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Andrew Bonventre:
Patch Set 9: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/226208. After addressing review feedback, remember to publish your drafts!