tools icon indicating copy to clipboard operation
tools copied to clipboard

changes needed for golang/go issue 36364

Open brianonn opened this issue 4 years ago • 14 comments

This PR is related to changes in issue golang/go#36364 and it's PR golang/go#37944.

This PR is only required if the PR golang/go#37944 is accepted for merge.

brianonn avatar Mar 19 '20 07:03 brianonn

This PR (HEAD: bd703d8230d2f5d21b4d6fa2261cb8e0295415cd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/224018 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Mar 19 '20 07:03 gopherbot

Message from Rebecca Stambler:

Patch Set 1: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/224018. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 23 '20 18:03 gopherbot

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=1a346bda


Please don’t reply on this GitHub thread. Visit golang.org/cl/224018. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 23 '20 18:03 gopherbot

Message from Michael Matloob:

Patch Set 1:

Hello, I'll wait for the golang.org/cl/224017 to be merged before reviewing this. Please respond to this change once that's done and I'll take a look.


Please don’t reply on this GitHub thread. Visit golang.org/cl/224018. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 23 '20 18:03 gopherbot

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/224018. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 23 '20 18:03 gopherbot

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit Logs at: https://source.cloud.google.com/results/invocations/b22d2331-8b34-44b6-924c-10914757635f


Please don’t reply on this GitHub thread. Visit golang.org/cl/224018. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 06 '20 17:10 gopherbot

Message from kokoro:

Patch Set 1: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS Logs at: https://source.cloud.google.com/results/invocations/b22d2331-8b34-44b6-924c-10914757635f


Please don’t reply on this GitHub thread. Visit golang.org/cl/224018. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 06 '20 17:10 gopherbot

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=1a346bda


Please don’t reply on this GitHub thread. Visit golang.org/cl/224018. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 15 '20 03:10 gopherbot

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/224018. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 15 '20 03:10 gopherbot

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=1a346bda


Please don’t reply on this GitHub thread. Visit golang.org/cl/224018. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot

Message from Michael Matloob:

Patch Set 1:

Hello, I'll wait for the golang.org/cl/224017 to be merged before reviewing this. Please respond to this change once that's done and I'll take a look.


Please don’t reply on this GitHub thread. Visit golang.org/cl/224018. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/224018. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit Logs at: https://source.cloud.google.com/results/invocations/b22d2331-8b34-44b6-924c-10914757635f


Please don’t reply on this GitHub thread. Visit golang.org/cl/224018. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot

Message from kokoro:

Patch Set 1: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS Logs at: https://source.cloud.google.com/results/invocations/b22d2331-8b34-44b6-924c-10914757635f


Please don’t reply on this GitHub thread. Visit golang.org/cl/224018. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot