tools
tools copied to clipboard
golang
go/analysis/passes/initflagparse: add check for avoid flag.Parse at init
I made the changes to fix the naif approach, but I would like to know how much we want to complicate the things here.
For example, now we have a false positive if you use other package called flag what have a function Parse and it is used in the init.
Other problem can be a function creation during init what contains the flag.Parse or functions called from init that calls the flag.Parse.
I guess we want to fix the main straig forward case (what is already solved with this PR) and maybe get rid of the case where the flag package is not the built-in flag package.
The other options are more complicated and I'm not sure if provides much value.
I'm also not very sure about the naming of things is correct.
This PR fixes the golang/go#33190 ticket
This PR (HEAD: b3bcc7c928d4fa5c23e3ad11f8d2cdbde282e541) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/218757 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Agniva De Sarker:
Patch Set 2:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/218757. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 2d1136b937a65f4ef8960e34c8b37ebf4efe88e0) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/218757 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Bryan C. Mills:
Patch Set 4: Run-TryBot+1 Code-Review+1
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/218757. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 4:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=9b4bbe24
Please don’t reply on this GitHub thread. Visit golang.org/cl/218757. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 4:
Build is still in progress... This change failed on linux-amd64 (Go 1.12.x): See https://storage.googleapis.com/go-build-log/249c282c/linux-amd64_e727300a.log
Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/218757. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 26c541cfdf1822e8ed3915a6b6d75f0c53962d70) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/218757 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Agniva De Sarker:
Patch Set 5: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/218757. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 5:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=98e5ab4b
Please don’t reply on this GitHub thread. Visit golang.org/cl/218757. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 5:
Build is still in progress... This change failed on linux-amd64 (Go 1.12.x): See https://storage.googleapis.com/go-build-log/46cb0161/linux-amd64_f3dbed63.log
Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/218757. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 5: TryBot-Result-1
10 of 10 TryBots failed: Failed on linux-amd64 (Go 1.12.x): https://storage.googleapis.com/go-build-log/46cb0161/linux-amd64_f3dbed63.log Failed on linux-amd64 (Go 1.13.x): https://storage.googleapis.com/go-build-log/a7acf9af/linux-amd64_1fe6ecca.log Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/6917529c/freebsd-amd64-12_0_54d0d25f.log Failed on linux-amd64: https://storage.googleapis.com/go-build-log/6917529c/linux-amd64_1eb13db8.log Failed on linux-386: https://storage.googleapis.com/go-build-log/6917529c/linux-386_bba726a3.log Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/6917529c/windows-amd64-2016_59274b8a.log Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/6917529c/openbsd-amd64-64_bb57661a.log Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/6917529c/windows-386-2008_49fa622b.log Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/6917529c/linux-amd64-race_78ba76d5.log Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/6917529c/android-amd64-emu_e6c2d608.log
Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/218757. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 5:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/218757. After addressing review feedback, remember to publish your drafts!
Message from Ian Cottrell:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/218757. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 986361742033e34b7eca524a298b6a0e9a996448) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/218757 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Jesús Espino:
Patch Set 6:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/218757. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 4:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=9b4bbe24
Please don’t reply on this GitHub thread. Visit golang.org/cl/218757. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 4:
Build is still in progress... This change failed on linux-amd64 (Go 1.12.x): See https://storage.googleapis.com/go-build-log/249c282c/linux-amd64_e727300a.log
Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/218757. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 5:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=98e5ab4b
Please don’t reply on this GitHub thread. Visit golang.org/cl/218757. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 5:
Build is still in progress... This change failed on linux-amd64 (Go 1.12.x): See https://storage.googleapis.com/go-build-log/46cb0161/linux-amd64_f3dbed63.log
Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/218757. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 5: TryBot-Result-1
10 of 10 TryBots failed: Failed on linux-amd64 (Go 1.12.x): https://storage.googleapis.com/go-build-log/46cb0161/linux-amd64_f3dbed63.log Failed on linux-amd64 (Go 1.13.x): https://storage.googleapis.com/go-build-log/a7acf9af/linux-amd64_1fe6ecca.log Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/6917529c/freebsd-amd64-12_0_54d0d25f.log Failed on linux-amd64: https://storage.googleapis.com/go-build-log/6917529c/linux-amd64_1eb13db8.log Failed on linux-386: https://storage.googleapis.com/go-build-log/6917529c/linux-386_bba726a3.log Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/6917529c/windows-amd64-2016_59274b8a.log Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/6917529c/openbsd-amd64-64_bb57661a.log Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/6917529c/windows-386-2008_49fa622b.log Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/6917529c/linux-amd64-race_78ba76d5.log Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/6917529c/android-amd64-emu_e6c2d608.log
Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/218757. After addressing review feedback, remember to publish your drafts!