tools icon indicating copy to clipboard operation
tools copied to clipboard

Published 20 hours ago • verified publisher icon golang

Identify context cancellation error in packages.loader.loadPackage

Open mmirolim opened this issue 5 years ago • 29 comments

Identify context cancellation in packages loader.loadPackage and do not log it as "unknow error" Fixes #37115

mmirolim avatar Feb 07 '20 19:02 mmirolim

This PR (HEAD: 324f3848e793500ec6b63905d588348e292d06e5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/218577 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Feb 07 '20 19:02 gopherbot

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 07 '20 19:02 gopherbot

Message from Michael Matloob:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 07 '20 19:02 gopherbot

This PR (HEAD: 5b2b3b08771b817e17172db4677969c3779cc2f5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/218577 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Feb 07 '20 20:02 gopherbot

Message from Rebecca Stambler:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 07 '20 21:02 gopherbot

This PR (HEAD: 40493acd100d8164c53a8080543d7958cb4c9861) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/218577 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Feb 08 '20 07:02 gopherbot

This PR (HEAD: 926907e94f6f642e88aca8a8b3cac319acb321d7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/218577 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Feb 08 '20 07:02 gopherbot

Message from Rebecca Stambler:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 10 '20 22:02 gopherbot

This PR (HEAD: c405b6358889d94c5258b60bb636f2c6a4f16035) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/218577 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Feb 10 '20 23:02 gopherbot

Message from Mirolim Mirzakhmedov:

Patch Set 5:

(4 comments)

When can it be merged?

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 13 '20 09:02 gopherbot

Message from Rebecca Stambler:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 13 '20 21:02 gopherbot

Message from Mirolim Mirzakhmedov:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 14 '20 14:02 gopherbot

Message from Mirolim Mirzakhmedov:

Patch Set 5:

What should we do with this fix?

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 19 '20 06:02 gopherbot

Message from Rebecca Stambler:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 19 '20 16:02 gopherbot

Message from Mirolim Mirzakhmedov:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 20 '20 07:02 gopherbot

Message from Mirolim Mirzakhmedov:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 20 '20 10:02 gopherbot

Message from Rebecca Stambler:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 20 '20 14:02 gopherbot

This PR (HEAD: b7788ec4719e4379e42a7f18c26790ac943a85b9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/218577 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Feb 20 '20 15:02 gopherbot

Message from Mirolim Mirzakhmedov:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 20 '20 15:02 gopherbot

Message from Michael Matloob:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 20 '20 16:02 gopherbot

This PR (HEAD: 1c3ff07f929e9a4742eec901bda0530317595341) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/218577 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Feb 20 '20 17:02 gopherbot

Message from Mirolim Mirzakhmedov:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 20 '20 17:02 gopherbot

Message from Mirolim Mirzakhmedov:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 20 '20 18:02 gopherbot

Message from Michael Matloob:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 20 '20 18:02 gopherbot

Message from Mirolim Mirzakhmedov:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 20 '20 18:02 gopherbot

Message from Michael Matloob:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 24 '20 18:02 gopherbot

Message from Mirolim Mirzakhmedov:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 24 '20 21:02 gopherbot

Message from Michael Matloob:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 25 '20 15:02 gopherbot

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/218577. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 15 '20 03:10 gopherbot