tools
tools copied to clipboard
golang
go/packages: optimize loading without overlays
Both of determineEnv and determineRootDirs calls take 100-200ms on MacBook Pro. Right now they are needed in most cases only for overlay processing. Optimize: call them only when overlays are set.
This PR (HEAD: e9260b99c8f12401ae5849557112d2cab8a085cf) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/195357 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Michael Matloob:
Patch Set 1: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/195357. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 1:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=2fb79fc0
Please don’t reply on this GitHub thread. Visit golang.org/cl/195357. After addressing review feedback, remember to publish your drafts!
Message from Michael Matloob:
Patch Set 1:
Is this calling slowness? We shouldn't be blocking on determineEnv or determineRootDirs, right?
Please don’t reply on this GitHub thread. Visit golang.org/cl/195357. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 1: TryBot-Result+1
TryBots are happy.
Please don’t reply on this GitHub thread. Visit golang.org/cl/195357. After addressing review feedback, remember to publish your drafts!
Message from Denis Isaev:
Patch Set 1:
Patch Set 1:
Is this calling slowness? We shouldn't be blocking on determineEnv or determineRootDirs, right?
Yes, on my MacBook pro the final loading time was 100-200ms slower even it's parallel.
Please don’t reply on this GitHub thread. Visit golang.org/cl/195357. After addressing review feedback, remember to publish your drafts!
Message from Michael Matloob:
Patch Set 1:
Patch Set 1:
Patch Set 1:
Is this calling slowness? We shouldn't be blocking on determineEnv or determineRootDirs, right?
Yes, on my MacBook pro the final loading time was 100-200ms slower even it's parallel.
Do you know why that's happening? I don't want to make this change without understanding how it helps.
Please don’t reply on this GitHub thread. Visit golang.org/cl/195357. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 1:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=2fb79fc0
Please don’t reply on this GitHub thread. Visit golang.org/cl/195357. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 1: TryBot-Result+1
TryBots are happy.
Please don’t reply on this GitHub thread. Visit golang.org/cl/195357. After addressing review feedback, remember to publish your drafts!