time
time copied to clipboard
rate: Avoid precision loss with edge cases
When burst is 1, there would be edge cases we get tokens of 0.9999999999997222 due to float64 multiplication/division rounding out value. So avoid those calculation when 'last' is old enough
Fixes golang/go#46579
This PR (HEAD: 81b70a964cff02d23aa6bdcd1b79c14843d996dd) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/time/+/325289 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Go Bot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/325289. After addressing review feedback, remember to publish your drafts!