text
text copied to clipboard
golang
x/text: Add Go modules support. Updates #24661
Fixes go modules support for this project.
See also https://github.com/golang/go/issues/24661
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
This PR (HEAD: f037251fef5d93c21184bdfce1741fa936f7c6e4) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/text/+/189346 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gobot Gobot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/189346. After addressing review feedback, remember to publish your drafts!
Message from thepudds:
Patch Set 1:
ssoroka, thanks for sending this!
One very minor comment is that the commit message title should probably start "x/text: ", I think, and then a lowercase letter after the ':'.
That might seem nit picky, but the consistency helps power some workflows, including I think even some dashboards like https://goissues.org/golang.org/x/text .
Also, the commit message probably should end with:
Updates #24661
Here are some more tips: https://golang.org/doc/contribute.html#commit_messages
Finally, I should also point out that I'm more-or-less a random member of the community and not a member of the Go team, so you should probably listen to pretty much anyone else before me. ;-)
Please don’t reply on this GitHub thread. Visit golang.org/cl/189346. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 059a5b1dfb6e3c931765fdc5ad8a49299f7bf55b) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/text/+/189346 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
I'm having some trouble getting this package working after the patch (though I never had it working before the patch). I suspect there's some other issues here, and I don't have any more time to spend on this. going to switch to a different solution.
Message from Marcel van Lohuizen:
Patch Set 3: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/189346. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 3:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=3d44b640
Please don’t reply on this GitHub thread. Visit golang.org/cl/189346. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 3:
Build is still in progress... This change failed on linux-amd64 (Go 1.13.x): See https://storage.googleapis.com/go-build-log/abfbc055/linux-amd64_a8de9034.log
Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/189346. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 3: TryBot-Result-1
9 of 10 TryBots failed: Failed on linux-amd64 (Go 1.13.x): https://storage.googleapis.com/go-build-log/abfbc055/linux-amd64_a8de9034.log Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/05511a5c/freebsd-amd64-12_0_40e2d876.log Failed on linux-amd64: https://storage.googleapis.com/go-build-log/05511a5c/linux-amd64_276b37b3.log Failed on linux-amd64 (Go 1.12.x): https://storage.googleapis.com/go-build-log/8d72096b/linux-amd64_feda22ce.log Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/05511a5c/openbsd-amd64-64_2a61361d.log Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/05511a5c/windows-386-2008_51fd7c7c.log Failed on linux-386: https://storage.googleapis.com/go-build-log/05511a5c/linux-386_ff449680.log Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/05511a5c/linux-amd64-race_8483f2a8.log Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/05511a5c/windows-amd64-2016_0c18c005.log
Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/189346. After addressing review feedback, remember to publish your drafts!
This is an important PR. https://stackoverflow.com/questions/60561353/how-to-work-with-gotext-extract-if-i-use-go-mod
Message from Go Bot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/189346. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 3:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=3d44b640
Please don’t reply on this GitHub thread. Visit golang.org/cl/189346. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 3:
Build is still in progress... This change failed on linux-amd64 (Go 1.13.x): See https://storage.googleapis.com/go-build-log/abfbc055/linux-amd64_a8de9034.log
Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/189346. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 3: TryBot-Result-1
9 of 10 TryBots failed: Failed on linux-amd64 (Go 1.13.x): https://storage.googleapis.com/go-build-log/abfbc055/linux-amd64_a8de9034.log Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/05511a5c/freebsd-amd64-12_0_40e2d876.log Failed on linux-amd64: https://storage.googleapis.com/go-build-log/05511a5c/linux-amd64_276b37b3.log Failed on linux-amd64 (Go 1.12.x): https://storage.googleapis.com/go-build-log/8d72096b/linux-amd64_feda22ce.log Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/05511a5c/openbsd-amd64-64_2a61361d.log Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/05511a5c/windows-386-2008_51fd7c7c.log Failed on linux-386: https://storage.googleapis.com/go-build-log/05511a5c/linux-386_ff449680.log Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/05511a5c/linux-amd64-race_8483f2a8.log Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/05511a5c/windows-amd64-2016_0c18c005.log
Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/189346. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/189346. After addressing review feedback, remember to publish your drafts!