golang
collate: fix Compare[String] funcs to use key comparisons
Change collator.Compare and collator.CompareString funcs to just do bytes.Compare
on the keys of the two strings.
I'll be honest, I don't know why Compare/compare() was implemented how it was versus doing what I'm doing here. Looks like it was last touched in 2013 when @mpvl moved it to this repo from somewhere else.
And add unit tests for the UCA Variable Weighting examples (https://www.unicode.org/reports/tr10/#Variable_Weighting_Examples). I had thought they weren't implemented at all because 1) CompareString was broken and 2) I wasn't adding the "-ks-level4" language tag option to actually enable Shift-Trimmed fully. Correcting those two things and they all pass!
Also add a comment about how the Collator is not safe to use concurrently.
Fixes golang/go#68166
This PR (HEAD: f1daf0a8721cbd3ea5014322eaf9b36dc0d7334a) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/text/+/638717.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/638717. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://go.dev/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/638717. After addressing review feedback, remember to publish your drafts!
Message from Jorropo:
Patch Set 1: Commit-Queue+1
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/638717. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-12-25T07:05:54Z","revision":"775c78e7ef1b10424cf7ddd4bad66764ae2607cf"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/638717. After addressing review feedback, remember to publish your drafts!
Message from Jorropo:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/638717. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/638717. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/638717. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 7e21e25a1e99f1ca4592cbdb0ea0a401c6b2b4d4) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/text/+/638717.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gabriel Burt:
Patch Set 2:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/638717. After addressing review feedback, remember to publish your drafts!
Message from Gabriel Burt:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/638717. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 14ca72f6771ba813ebba25fd20b3bdffbd026669) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/text/+/638717.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gabriel Burt:
Patch Set 4:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/638717. After addressing review feedback, remember to publish your drafts!
Message from Gabriel Burt:
Patch Set 4:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/638717. After addressing review feedback, remember to publish your drafts!
Message from Jorropo:
Patch Set 4:
(4 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/638717. After addressing review feedback, remember to publish your drafts!
Message from Gabriel Burt:
Patch Set 4:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/638717. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 086270d37581eb92fc91a57ef30a17c2d4a99c67) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/text/+/638717.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.