term
term copied to clipboard
golang
Introduce ReadPasswordWithContext
Introduced the ReadPasswordWithContext function that allows to read a password from the terminal with support for cancellation. This is a suggestion to address https://github.com/golang/go/issues/31180.
This is a work-in-progress PR for collecting the first feedback. Please do not merge!
Hey there, this PR is an attempt to resolve https://github.com/golang/go/issues/31180. The current state is notready but I'd like to collect the first feedback, if this the idea is in principle worth following up and if someone has a bett er approach to resolve the issue.
Two notes on this PR:
- The Windows version does not work currently and I'm stuck there. The used
f := os.NewFile(uintptr(h), "stdin")construct is not closeable and AFAICS does Windows not support nonblocking IO access to the terminal. Any suggestion on how to unblock this is more than welcome - The Unix reader works by nonblocking UI and polling, which is not ideal. If anyone has an idea for an alternative approach ...
This PR (HEAD: 900d0434b217b18519eb6a903b8bdb127118ec70) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/term/+/473635 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/473635. After addressing review feedback, remember to publish your drafts!