sys
sys copied to clipboard
golang
#24775. Windows Service does not stop issue fixed
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
This PR (HEAD: 3010eebb2e05f3246b9e4b93730bc565415f8fc5) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/#/c/sys/+/105795 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gobot Gobot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/105795. After addressing review feedback, remember to publish your drafts!
Message from Brad Fitzpatrick:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/105795. After addressing review feedback, remember to publish your drafts!
@emli, we're still waiting on @azretkenzhaliev to address the review feedback.
Message from Alex Brainman:
Patch Set 1:
azretkenzhaliev
I don't see what the problem in issue #24775 is. Please reply to my questions at https://github.com/golang/go/issues/24775#issuecomment-380038228 before I will review this CL.
Thank you.
Alex
Please don’t reply on this GitHub thread. Visit golang.org/cl/105795. After addressing review feedback, remember to publish your drafts!
Message from Gerrit User 5976:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/105795. After addressing review feedback, remember to publish your drafts!
Message from Gerrit User 5065:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/105795. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 1:
azretkenzhaliev
I don't see what the problem in issue #24775 is. Please reply to my questions at https://github.com/golang/go/issues/24775#issuecomment-380038228 before I will review this CL.
Thank you.
Alex
Please don’t reply on this GitHub thread. Visit golang.org/cl/105795. After addressing review feedback, remember to publish your drafts!