sys icon indicating copy to clipboard operation
sys copied to clipboard
verified publisher icon golang

windows: add virtual key codes and console input consts

Open aymanbagabas opened this issue 1 year ago • 10 comments

This adds console input related key codes and consts

aymanbagabas avatar Oct 21 '24 14:10 aymanbagabas

This PR (HEAD: 7db5f02d8518248f02d6ea5593caa4a830b42d18) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/621495.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Oct 21 '24 15:10 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 21 '24 15:10 gopherbot

Message from Ayman Bagabas:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 21 '24 15:10 gopherbot

Hey @alexbrainman, can we get this in? This only contains key and input codes.

aymanbagabas avatar Jan 30 '25 20:01 aymanbagabas

Message from Ayman Bagabas:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 04 '25 15:02 gopherbot

Message from abner chenc:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 12 '25 03:03 gopherbot

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-03-12T03:31:44Z","revision":"8643fd8114b1b7f7c24cfd4756da624cf1212fd6"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 12 '25 03:03 gopherbot

Message from abner chenc:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 12 '25 03:03 gopherbot

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 12 '25 03:03 gopherbot

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 12 '25 03:03 gopherbot

Message from Alex Brainman:

Patch Set 1:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 20 '25 06:04 gopherbot

This PR (HEAD: 8e534f4589e57f1d681e72877917578a0ed67622) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/621495.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Apr 20 '25 09:04 gopherbot

Message from Ayman Bagabas:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 20 '25 09:04 gopherbot

Message from Alex Brainman:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 21 '25 08:04 gopherbot

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-04-21T08:00:07Z","revision":"126dbf2db2f2ade2506f9aac5066bff0433a1e98"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 21 '25 08:04 gopherbot

Message from Alex Brainman:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 21 '25 08:04 gopherbot

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 21 '25 08:04 gopherbot

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 21 '25 08:04 gopherbot

Message from Alex Brainman:

Patch Set 2: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 21 '25 08:04 gopherbot

Message from Junyang Shao:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 22 '25 17:04 gopherbot

Message from Michael Pratt:

Patch Set 2: Auto-Submit+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/621495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 22 '25 17:04 gopherbot

This PR is being closed because golang.org/cl/621495 has been merged.

gopherbot avatar Apr 22 '25 17:04 gopherbot