golang
unix: Update z/OS implementation of fcntl and mmap
- Adds a wrapper function around fcntl to handle different operation types and new fcntl implementation that accepts uintptr as an arg
- Adds support for calling mmap/munmap with address pointers
- Adds accompanying tests for new functions
This PR (HEAD: 07e32a4ab797c7baffdb50f8407cf679cabf1dae) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/610296.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/610296. After addressing review feedback, remember to publish your drafts!
Message from Bill O'Farrell:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/610296. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/610296. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-10-24T23:57:38Z","revision":"dcdefeaec23009a98719e3a7b8f3005af0b2213d"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/610296. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/610296. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
This CL has failed the run. Reason:
Tryjob golang/try/x_sys-gotip-windows-amd64 has failed with summary (view all results):
- go on master (commit 15c5580)
- sys on master (change 610296)
Build or test failure, click here for results.
To reproduce, try gomote repro 8733151992568533185.
Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/610296. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/610296. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/610296. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-10-25T00:00:28Z","revision":"a2a1613a93b1f0a20580ebbf5f8ade7bc320aa49"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/610296. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 2: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/610296. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/610296. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/610296. After addressing review feedback, remember to publish your drafts!
Message from bcd a:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/610296. After addressing review feedback, remember to publish your drafts!
Message from Dmitri Shuralyov:
Patch Set 3: Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/610296. After addressing review feedback, remember to publish your drafts!