golang
windows: add console codepage api
Add setter/getter for console input/output codepages. This is useful to set the console expected codepage instead of converting it to UTF-16 before writing.
This PR (HEAD: 2c38ffbb0cb7322536c65bcecacc9e594ead5919) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/599395.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. After addressing review feedback, remember to publish your drafts!
Message from Ayman Bagabas:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 1:
(5 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 93c06e27a0ac885d9da288985fc1df87921626c0) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/599395.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Ayman Bagabas:
Patch Set 2:
(5 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 2: Commit-Queue+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-08-27T10:34:06Z","revision":"d97c91d9ac8334c030ae09bf145da97fe11a5bb9"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 2: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. After addressing review feedback, remember to publish your drafts!
Message from Alex Brainman:
Patch Set 2: Code-Review+2
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. After addressing review feedback, remember to publish your drafts!
Message from Michael Pratt:
Patch Set 2: Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. After addressing review feedback, remember to publish your drafts!
Message from Cherry Mui:
Patch Set 2: Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/599395. After addressing review feedback, remember to publish your drafts!