sys icon indicating copy to clipboard operation
sys copied to clipboard

windows: add net user enum

Open JoeyShapiro opened this issue 1 year ago • 11 comments

In the go windows package, you can get user information by using NetUserGetInfo along with a specified level. However, there is no way to get a list of the users. The only options are to

  1. know the users,
  2. brute force users, or
  3. use an external tool or command (net users).

I suggest adding a function that implements the windows api for NetUserEnum. This will allow a built in way to enumerate users and follow the standard.

A side note is that I used buf **byte because it is how the others are done, but using buf *byte works just as well.

JoeyShapiro avatar Apr 12 '24 15:04 JoeyShapiro

This PR (HEAD: 3d01bca920d95280311d47b8e6a9b91d472bea98) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/578475.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Apr 12 '24 15:04 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 12 '24 15:04 gopherbot

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://go.dev/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 12 '24 15:04 gopherbot

Message from Alex Brainman:

Patch Set 1:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 05 '24 00:05 gopherbot

Message from Joey Shapiro:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 05 '24 01:05 gopherbot

Message from Alex Brainman:

Patch Set 3: Code-Review+2 Commit-Queue+1

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 05 '24 10:05 gopherbot

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-05-05T10:41:05Z","revision":"6f5f8d62e0e4df84627e5561d6a8d23225749216"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 05 '24 10:05 gopherbot

Message from Alex Brainman:

Patch Set 3: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 05 '24 10:05 gopherbot

Message from Go LUCI:

Patch Set 3:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 05 '24 10:05 gopherbot

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 05 '24 10:05 gopherbot

Message from Alex Brainman:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 05 '24 11:05 gopherbot

Message from Cherry Mui:

Patch Set 3: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 06 '24 17:05 gopherbot

Message from David Chase:

Patch Set 3: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/578475. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 09 '24 16:05 gopherbot

This PR is being closed because golang.org/cl/578475 has been merged.

gopherbot avatar May 09 '24 17:05 gopherbot