sync icon indicating copy to clipboard operation
sync copied to clipboard

Include a godoc link in the README

Open alex opened this issue 6 years ago • 6 comments

alex avatar Jul 22 '19 14:07 alex

This PR (HEAD: be173489e1079c063c1452d4a79c96c20124faf5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sync/+/187077 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Jul 22 '19 14:07 gopherbot

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/187077. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 22 '19 14:07 gopherbot

Message from Bryan C. Mills:

Patch Set 1:

The structure of this README mirrors the structure of the other Go repositories (for example, see https://go.googlesource.com/net/+/refs/heads/master/README.md).

If we're going to add links to one, we should add links consistently to all of them. On the other hand, I'd rather hold off until we can link straight to the new module discovery site (see https://blog.golang.org/modules2019#TOC_7.).


Please don’t reply on this GitHub thread. Visit golang.org/cl/187077. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 02 '19 17:08 gopherbot

Message from Alex Gaynor:

Patch Set 1:

I think adding links to all of these repos would be a good improvement, and I'm happy to go through and do a PR for each of them.


Please don’t reply on this GitHub thread. Visit golang.org/cl/187077. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 02 '19 17:08 gopherbot

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/187077. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 15 '20 03:10 gopherbot

Message from Julie Qiu:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/187077. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 27 '20 01:10 gopherbot