golang
singleflight: increase concurrency efficieny of dochan
In Singlelight, the function of mutex is to protect the atomic access of critical resources in the map. In the following optimization, after deleting the key of the map, the mutex can be released without being responsible for each chan
Benchmark code
type user struct {
Name string
}
func BenchmarkSingleflight(b *testing.B) {
group := singleflight.Group{}
b.RunParallel(func(pb *testing.PB) {
for pb.Next() {
for i := 0; i < 1000; i++ {
_ = <-group.DoChan(strconv.FormatInt(int64(i), 10), func() (inner interface{}, err error) {
inner = user{
Name: "hello",
}
return
})
}
}
})
}
Before optimization
After optimization
summary
Overall, this has a significant performance improvement for singlelight, with an average decrease of about 15% in time overhead
In a production environment, we do not want to use a global lock for sending results to every channel of doChan. This global lock is not necessarily responsible for this, and it is clearly stated in the performance analysis report that this can effectively reduce time overhead
This PR (HEAD: ee123ad9d6992b25fca6694603c9916bb84fa744) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/sync/+/632095.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/632095. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/632095. After addressing review feedback, remember to publish your drafts!
Message from Xiyang Jiang:
Patch Set 1: Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/632095. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/632095. After addressing review feedback, remember to publish your drafts!
Message from Xiyang Jiang:
Patch Set 3:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/632095. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 3: Hold+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/632095. After addressing review feedback, remember to publish your drafts!
Message from Xiyang Jiang:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/632095. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/632095. After addressing review feedback, remember to publish your drafts!
Message from Xiyang Jiang:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/632095. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/632095. After addressing review feedback, remember to publish your drafts!
Message from Xiyang Jiang:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/632095. After addressing review feedback, remember to publish your drafts!
Message from Robert Findley:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/632095. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 3:
(5 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/632095. After addressing review feedback, remember to publish your drafts!
Message from Alan Donovan:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/632095. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 3:
(5 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/632095. After addressing review feedback, remember to publish your drafts!