protobuf Correctly advertise editions support

Aug 05 '24 20:08 mkruskal-google

Thank you for the attention, but the github.com/golang/protobuf module is frozen except for essential bug fixes and regressions from one of the more recent versions.

Aug 06 '24 03:08 puellanivis

I would actually label this a regression/bug fix. AFAICT this plugin should support edition 2023 just fine because it uses the official golang protoc plugin infra, edition 2023 doesn't affect RPC codegen, and it already sets FEATURE_SUPPORTS_EDITIONS by copying SupportedFeatures. It just fails to specify the edition window it supports, so anyone using this plugin will hit protoc errors when they try to upgrade to editions

Aug 06 '24 16:08 mkruskal-google

FWIW I hit this trying to migrate someone to editions that was using this plugin :). I ended up just switching them to the newer one, but I figured there might be edge cases where that's not as much of an option.

Aug 08 '24 16:08 mkruskal-google

Should this PR be closed now?

Jan 06 '25 18:01 jhump

Sorry, I didn’t actually see this PR before.

@jhump Why are you suggesting to close this PR?

@mkruskal-google Are you still looking to get this merged?

Jan 07 '25 08:01 stapelberg

@stapelberg, it seemed like the conversation was suggesting that people that want to use Editions should migrate to the newer version of protoc-gen-go, over in google.golang.org/protobuf.

Jan 07 '25 15:01 jhump