pkgsite icon indicating copy to clipboard operation
pkgsite copied to clipboard

Published 20 hours ago • verified publisher icon golang

x/pkgsite: trim HTTP or HTTPS Scheme from source code links

Open nickel8448 opened this issue 4 years ago • 4 comments

A new template function is created, which trims the scheme of the URL. Tests in server_test.go are modified accordingly.

Fixes golang/go#40943

nickel8448 avatar Oct 31 '20 23:10 nickel8448

This PR (HEAD: 85c8144691f6a3f13bf1da6c0b844ea626368415) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/pkgsite/+/266998 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Oct 31 '20 23:10 gopherbot

While reading through the code I found that several test cases were using sample.ModulePath for RepoUrl/RepositoryURL variables since this change makes ModulePath and RepoURL the same, I changed sample.ModulePath to sample.RepositoryURL wherever required. (Sample)

nickel8448 avatar Oct 31 '20 23:10 nickel8448

Message from Jonathan Amsterdam:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/266998. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 02 '20 14:11 gopherbot

Message from Jonathan Amsterdam:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/266998. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot