golang
x/oauth2: apply the expires_in value returned by the server to Token.ExpiresIn
In typical usage, Token.Expiry alone is sufficient. However, the ExpiresIn field was introduced in golang/go#61417. Even when a server returns an expires_in value in methods like Config.Exchange, only the Expiry field is updated, leaving ExpiresIn unchanged, which can cause confusion.
This change ensures that the ExpiresIn field is properly updated when the server provides an expires_in value.
This PR (HEAD: 20124de0953da01c12fd906a3c298bac1eeeb340) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/621215.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621215. After addressing review feedback, remember to publish your drafts!
Message from Matt Hickford:
Patch Set 1: Code-Review+2 Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/621215. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621215. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1: TryBot-Result+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621215. After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 2: Commit-Queue+1
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621215. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-04-16T20:34:01Z","revision":"de6b96220c46faf3d272d71d8aa3c9d14bc26038"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/621215. After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 2: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/621215. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/621215. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/621215. After addressing review feedback, remember to publish your drafts!
Message from Matt Hickford:
Patch Set 2: Code-Review+2
Please don’t reply on this GitHub thread. Visit golang.org/cl/621215. After addressing review feedback, remember to publish your drafts!