golang
oauth2: add option to override the url values for refresh token
- Assisted our team getting compatibility with RFC: https://datatracker.ietf.org/doc/html/rfc7523
- Was trying to get tokens as required by azure-devops-oauth
This PR (HEAD: 7bc4a859ea743e74d3a92a7cc7dc724f5f2826ed) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/592517.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/592517. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/592517. After addressing review feedback, remember to publish your drafts!
Message from sabith ks:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/592517. After addressing review feedback, remember to publish your drafts!
if someone in their code defined an interface matching TokenSource, it would no longer match.
if someone in their code defined an interface matching TokenSource, it would no longer match.
Thanks @seankhliao for taking a look at this.
Will something like https://github.com/golang/oauth2/compare/master...stackgenhq:oauth2:feature/support_rfc7523_refresh?expand=1 be acceptable ?