oauth2 icon indicating copy to clipboard operation
oauth2 copied to clipboard

oauth2: remove extra period

Open darkfeline opened this issue 1 year ago • 10 comments

darkfeline avatar May 21 '24 23:05 darkfeline

This PR (HEAD: 0ae4d52c2546f0ffceab567f7e58e5748d033e37) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/587017.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar May 21 '24 23:05 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/587017. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 21 '24 23:05 gopherbot

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/587017. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 22 '24 00:05 gopherbot

This PR (HEAD: ca611fe5a361db93b76e758ec7d956b0768039e5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/587017.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar May 22 '24 00:05 gopherbot

Message from Ian Lance Taylor:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/587017. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 22 '24 01:05 gopherbot

Message from Ian Lance Taylor:

Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/587017. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 22 '24 01:05 gopherbot

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-05-22T01:01:15Z","revision":"a6b84d3e24de16511ee988a900392289e9f8c39b"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/587017. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 22 '24 01:05 gopherbot

Message from Ian Lance Taylor:

Patch Set 3: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/587017. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 22 '24 01:05 gopherbot

Message from Go LUCI:

Patch Set 3:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/587017. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 22 '24 01:05 gopherbot

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/587017. After addressing review feedback, remember to publish your drafts!

gopherbot avatar May 22 '24 01:05 gopherbot

This PR is being closed because golang.org/cl/587017 has been merged.

gopherbot avatar Mar 19 '25 23:03 gopherbot