oauth2 icon indicating copy to clipboard operation
oauth2 copied to clipboard

Published 20 hours ago • verified publisher icon golang

wrap http client errors with %w

Open 1garo opened this issue 1 year ago • 8 comments

Closes #635

Wrap all client errors with %w, dropping the usage of %v.

go test passing image

1garo avatar Mar 14 '23 21:03 1garo

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Mar 14 '23 21:03 google-cla[bot]

This PR (HEAD: 4a57f80c2abdd9e078cb2a8f30d288b6c5c0f61a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/476316 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Mar 14 '23 22:03 gopherbot

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/476316. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 14 '23 22:03 gopherbot

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/476316. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 15 '23 01:03 gopherbot

Message from Alexandre Vardai:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/476316. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 15 '23 14:03 gopherbot

@1garo the PR has conflicts.

trakhimenok avatar Oct 06 '23 12:10 trakhimenok

@1garo the PR has conflicts.

Done!

1garo avatar Oct 12 '23 14:10 1garo

This PR (HEAD: 1f19623bf1a869fa084e0b2cf07a27c97469a970) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/476316.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Oct 12 '23 14:10 gopherbot