oauth2
oauth2 copied to clipboard
golang
oauth2: document that provided context will be used in refresh requests.
The context given to Client() will be stored and reused for token refreshes througout the life of the Config. If the context expires e.g. during application startup, refresh attempts will fail. Add documentation and annotate the errors around this case so it's clear that token refresh, not the actual request, is the problem.
Updates #388
This PR (HEAD: bdee15b01288c57dab990734c316e4150ec1d401) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/oauth2/+/296469 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Go Bot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
Please don’t reply on this GitHub thread. Visit golang.org/cl/296469. After addressing review feedback, remember to publish your drafts!
Message from JBD (DO NOT USE):
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/296469. After addressing review feedback, remember to publish your drafts!