oauth2 icon indicating copy to clipboard operation
oauth2 copied to clipboard

Create slackv2.go for new slack Oauth endpoints

Open stevengill opened this issue 5 years ago • 6 comments

Slack has introduced granular scoped apps which uses a new OAuth endpoint. When you make a new slack app, this is the new default.

The previous slack endpoint still works for classic slack apps. So I figured it might make sense to offer both still. These classic slack apps can still be made and a majority of existing slack apps use them.

If y'all think it would be better just update slack.go instead of creating a new slackv2.go, let me know. I'm a go noob, so any advice would be appreciated.

Issue: https://github.com/golang/oauth2/issues/412

stevengill avatar Mar 10 '20 21:03 stevengill

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 10 '20 21:03 googlebot

@googlebot I fixed it.

stevengill avatar Mar 10 '20 21:03 stevengill

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 10 '20 21:03 googlebot

This PR (HEAD: 92b19d66ebc6f96021aebade8d386f266b78fd11) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/222781 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Mar 10 '20 22:03 gopherbot

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/222781. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 10 '20 22:03 gopherbot

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/222781. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 15 '20 03:10 gopherbot