oauth2 icon indicating copy to clipboard operation
oauth2 copied to clipboard

oauth2: validate token in reuseTokenSource

Open pratikmallya opened this issue 6 years ago • 3 comments

Without this check, for reuseTokenSource types that are created without a Token (which is permitted), the call to Token will fail since the value of the reuseTokenSource.t field (which holds the token) is nil.

pratikmallya avatar Jul 15 '19 02:07 pratikmallya

This PR (HEAD: 0e585044b61883d4cbeb43b79a8bb7ad19dab2d8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/186158 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Jul 15 '19 02:07 gopherbot

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/186158. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jul 15 '19 02:07 gopherbot

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/186158. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 15 '20 03:10 gopherbot