golang
More support for Google id-tokens
This adds a Config convenience layer for new JSON key support for google-signed id-tokens (https://github.com/golang/oauth2/commit/950ef44c6e079baf075030377d90bf0c7e4b7b7a)
This also adds a compute instance TokenSource
I didn't find any tests for the current compute instance metadata token source to emulate
cc @wlhee @salrashid123
This PR (HEAD: 49f68176603c282aff382a7ff35e6f0a1c6800ad) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/oauth2/+/182678 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gobot Gobot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/182678. After addressing review feedback, remember to publish your drafts!
Note - I'm still validating this on a compute instance, and have found some issues, so consider this WIP
This PR (HEAD: 1f93694b612a806f81ef346c9af6be34dd4cf56e) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/oauth2/+/182678 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Preston Holmes:
Patch Set 2:
I've validated this now WAI on a GCE instance
Please don’t reply on this GitHub thread. Visit golang.org/cl/182678. After addressing review feedback, remember to publish your drafts!
Message from Preston Holmes:
Patch Set 2:
the "integration test" run on GCE was https://gist.github.com/ptone/53c34e8d14501331ad4938de65a7aa14
Please don’t reply on this GitHub thread. Visit golang.org/cl/182678. After addressing review feedback, remember to publish your drafts!
Message from Preston Holmes:
Patch Set 2:
Note: I'm factoring the part that calls the metadata server into https://code-review.googlesource.com/c/gocloud/+/42110
Please don’t reply on this GitHub thread. Visit golang.org/cl/182678. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/182678. After addressing review feedback, remember to publish your drafts!