oauth2
oauth2 copied to clipboard
golang
Increase expireDelta time to 60 seconds
10 seconds token expire delta is too small as on poor connections one can easily end up with 401 error due to temporary network issues and lengthy TCP/IP retries. It leads to a rather misleading 401 authorization error.
The issue is observed in real-life with Google Cloud object storage and other services.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
This PR (HEAD: 0ad0f254e51b6f4e0efec48baa9b99e7b6e8f254) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/oauth2/+/157957 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gobot Gobot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/157957. After addressing review feedback, remember to publish your drafts!
Message from Brad Fitzpatrick:
Patch Set 1:
If we get a 401, we'd see the server's Date header, no? That might be a good time to learn the clock skew & adjust for future retries.
Something more principled like that seems preferable over just tweaking constants higher forever.
Please don’t reply on this GitHub thread. Visit golang.org/cl/157957. After addressing review feedback, remember to publish your drafts!
Message from Basikos Malento:
Patch Set 1: Code-Review+1
Patch Set 1:
If we get a 401, we'd see the server's Date header, no? That might be a good time to learn the clock skew & adjust for future retries.
I believe you get it wrong, it's not about clock skew (and BTW none of cloud libraries do this). Instead situation happens with correct clocks. It's just possible that correctly formed request is received in about ~1 min after being sent due to all the SYN / SSL handshake and data packet TCP retransmits.
Please don’t reply on this GitHub thread. Visit golang.org/cl/157957. After addressing review feedback, remember to publish your drafts!
Message from Brad Fitzpatrick:
Patch Set 1: Code-Review-1
In any case, this feels like a hacky fix and I'm not sure where it ends.
Please don’t reply on this GitHub thread. Visit golang.org/cl/157957. After addressing review feedback, remember to publish your drafts!
Message from Basikos Malento:
Patch Set 1:
In any case, this feels like a hacky fix and I'm not sure where it ends.
please suggest your ideas how to fix it nicer?
Please don’t reply on this GitHub thread. Visit golang.org/cl/157957. After addressing review feedback, remember to publish your drafts!
Message from Kate Hill:
Patch Set 1: Code-Review+1
Looks good to me and logical
Please don’t reply on this GitHub thread. Visit golang.org/cl/157957. After addressing review feedback, remember to publish your drafts!
Message from Alexey Neganov:
Patch Set 1: Code-Review+1
Looks as simple & reliable fix
Please don’t reply on this GitHub thread. Visit golang.org/cl/157957. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/157957. After addressing review feedback, remember to publish your drafts!
Message from Deleted User:
Patch Set 1: Code-Review+1
Patch Set 1:
If we get a 401, we'd see the server's Date header, no? That might be a good time to learn the clock skew & adjust for future retries.
I believe you get it wrong, it's not about clock skew (and BTW none of cloud libraries do this). Instead situation happens with correct clocks. It's just possible that correctly formed request is received in about ~1 min after being sent due to all the SYN / SSL handshake and data packet TCP retransmits.
Please don’t reply on this GitHub thread. Visit golang.org/cl/157957. After addressing review feedback, remember to publish your drafts!
Message from Deleted User:
Patch Set 1:
In any case, this feels like a hacky fix and I'm not sure where it ends.
please suggest your ideas how to fix it nicer?
Please don’t reply on this GitHub thread. Visit golang.org/cl/157957. After addressing review feedback, remember to publish your drafts!
Message from Deleted User:
Patch Set 1: Code-Review+1
Looks good to me and logical
Please don’t reply on this GitHub thread. Visit golang.org/cl/157957. After addressing review feedback, remember to publish your drafts!